> For the complete documentation index, see [llms.txt](https://docs.wellcomecollection.org/request-for-comments-rfcs/llms.txt). Markdown versions of documentation pages are available by appending `.md` to page URLs; this page is available as [Markdown](https://docs.wellcomecollection.org/request-for-comments-rfcs/015-how_we_work/code_reviews.md).

# Code Reviews

Code reviews are intended to ensure code changes meet a high standard and to share best practise between team members.

Code reviews should:

* Be performed by a developer who did not write the code.
* Require approval from:
  * **one** other developer in the case of project work
  * **two** developers (one of whom is from a different team) in the case of library changes.
* Not block merging, i.e. changes can be requested in later PRs where that change is not critical to the purpose of the existing PR.
* Ask for clarification where code or purpose is unclear.
* Be polite: assume the good intent of the person making the change.

Some guidelines:

* Nit picking is okay but should be labelled as such.
* Code style, indentation, etc is better handled by automated linting than by code review.
* Developers from any team can comment on any PR that they feel qualified to (it is expected that this happen).
* The developer who opened a PR should be the one to merge it.
* Examples of how to structure code or links to resources that clarify are helpful.


---

# Agent Instructions
This documentation is published with GitBook. GitBook is the documentation platform designed so that both humans and AI agents can read, navigate, and reason over technical content effectively. Learn more at gitbook.com.

## Querying This Documentation
If you need additional information that is not directly available in this page, you can query the documentation dynamically by asking a question.

Perform an HTTP GET request on the current page URL with the `ask` query parameter, and the optional `goal` query parameter:

```
GET https://docs.wellcomecollection.org/request-for-comments-rfcs/015-how_we_work/code_reviews.md?ask=<question>&goal=<endgoal>
```

`ask` is the immediate question: it should be specific, self-contained, and written in natural language.
`goal` is optional and describes the broader end goal you are ultimately trying to accomplish on behalf of the user. GitBook uses it to tailor the answer towards what is most useful for that goal.

The response will contain a direct answer to the question and relevant excerpts and sources from the documentation.

Use this mechanism when the answer is not explicitly present in the current page, you need clarification or additional context, or you want to retrieve related documentation sections.